Unblock Llama2 ONNX export w/ sdpa by falling back to manual impl #28823
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagocrepaldi
approved these changes
Feb 1, 2024
ArthurZucker
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Thanks for this! It's gonna be a bit hard to merge this. Would you mind checking if #27931 fixes the issue? It shall be merged before and should simplify all of that logic
|
Hi @ArthurZucker, I have validated the issue is fixed under your PR, thanks! Do you have an ETA when it will get merged? Our workstreams have been blocked by this issue for a while, we need to resolve this export issue asap. |
fxmarty
reviewed
Feb 5, 2024
| @@ -673,12 +673,22 @@ def forward( | |||
| output_attentions: bool = False, | |||
| use_cache: bool = False, | |||
| ) -> Tuple[torch.Tensor, Optional[torch.Tensor], Optional[Tuple[torch.Tensor]]]: | |||
| _jit_tracing = torch.jit.is_tracing() | |||
There was a problem hiding this comment.
This means that we call torch.jit.is_tracing as many times as there are layers.
|
I don't understand why this change is necessary. The error that is normally raised explicitly gives a solution. |
|
@ArthurZucker @BowenBao I believe we can close this issue now that #27931 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unblocks Llama2 ONNX export with sdpa by falling back to manual implementation.
Fixes #28610
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@fxmarty